means i have to build now a topology and join the lines which belongs to one leg.

.....

---

Hi Franco,

 

 

I suppose that the rule is:

 

If the attribute "A" of a line is equal to the attribute "C" of the previous line, then the two lines have to be connected.

 

Otherwise, the two lines should not be connected even if they are touching each other at the end nodes.

 

 

If my understanding is correct, this could be a way.

 

(1) LineJoiner

 

- List Name: _list

 

- Preserve Lines as Path Segments: Yes

 

 

(2) PathSplitter

 

- List Attribute: _list{}

 

 

The LineJoiner and the PathSplitter will sort the lines in their connecting order. If the input lines have been sorted in the order from the beginning, the two transformers are not essential.

 

 

(3) AttributeExposer

 

- Attributes to Expose: _group

 

 

(4) AttributeCreator with the "Prior/Subsequent Feature Attribute Retrieval" option (called "Multiple Feature Attribute Support" in FME 2014).

 

- Number of Prior Features: 1

 

- If Attribute is Missing, Null, or Empty: Use Empty String

 

- Attribute Name: _group

 

- Value (Conditional Value Setting):

 

If featurei-1]._group = <empty> Then 0

 

Else If A = featureÂ-1].C Then featuree-1]._group

 

Else featureg-1]._group+1

 

 

(5) LineJoiner_2

 

- Group By: _group

 

 

Takashi

---

Hi,

 

thank you Takashi...it function but i told you maybe not the full truth ;-))

first of all "use empty string" ??...i have only 3 options there : - Use Attribute Value, Use Fallback Value or Use Attribute Value of Closest Feature....??

 

but it function except here: (see screenshot)

 

 

 

the yellow line should be also connected with blue in the north, but i think that cannot function because the Line joiner has two options here (means two lines) the line in the north, which has the right attribute value, and the line turns left which has NOT the right attribute value....expect on this cases the line joiner DO FUNCTION.

 

 

Greetz

 

Franco

---

oh, sorry. I looked at the AttributeCreator in FME 2014.

 

In FME 2015, choose the "Use Fallback Value" option and leave blank the "Fallback Value" parameter field.

 

 

What kind of the rule for combining the yellow line and the northern blue line is?

---

its the same rule but he stops connecting where he have a right option and a wrong option....right option is blue in the north, wrong option is blue left...he do it right where 3 lines comes together and he has two wrong options....

---

hmm, not clear...

 

 

Perhaps your goal is to build a topologically clean network?

 

i.e. the blue lines should be divided at the point intersecting with the yellow line?

---

now the result is the line joiner stops connecting at the place but he shouldnt because the yellow line should be connected to the blue line in the north because the attribute values are right..but i think i've done a fault...I'm not so familiar with these expressions....added screenshots

 

 

 

 

 

 

 

Greetz

 

Franco

---

isn't it right to give him another option?

now he has option 1 attribute value is right do  connect........option 2 attribute value is wrong do not connect....but when he comes to a point where he have option 1 and option 2 should we give him not the possibility to decide for option 1...or is this already implented by this expression?

---

The Conditional Value Setting I intended should be:

 

 

 

---

hmm....i set it up that way...now the result is that he connects nothing......

line joiner is group by _group....think thats stays right or?

hmm....

---

i have for the test 9019 features and the _group attribute result after Attribute creator is from 0 til 9018

---

sad to hear that...

 

 

Well, rethink from the beginning.

 

The AttributeCreator approach requires that the input lines have been sorted in the connecting order. i.e. WSNO of the 1st line is equal to USLINKNO1 of the 2nd line, the 2nd WSNO is equal to USLINKNO1 of the 3rd, and so on.

 

If the lines have not been sorted, you will have to sort them beforehand.

 

 

In my first post, I suggested the LineJoiner+PathSplitter to do the sorting, but it would not work as expected since there are a node to which 3 lines connect together. I didn't assume such a situation.

 

 

Is there any condition which  can be used to sort the lines in the connecting order?

 

e.g. WSNO or USLINKNO1 value can be used to sort the lines?

---

hmmm....

i didnt take the option to sort them because they are sorted.......

i think i have confused you...

alle lines are sorted with this rule.....

but i have nodes where three lines comes together....and there i have 2 situations

1. situation...line 1 is connected to that point...line 2 should not be connected (has wrong attributes either) and line 3 should also not be connected (has wrong attributes either).....this is situation he checked after your first solution......

2. situation...line 1 is connected to that point....line 2 schould be connected (because of right attribute value) and line 3 should not be connected (because of worng attribute value).....this situation doesn't work because he ends to connect here.

sry...for my confusing declarations

Greetz

 

Franco

---

no attribute value alone can be used for sorting.....only the logical connection between USLINKNO1 and WSNO...

---

The AttributeCreator gives an identical "_group" number to each line while "WSNO" of the prior line is equal to "USLINKNO1" of the current line.

 

For example, if these lines have come, all of them will have same group number.

 

Line1: WSNO = 1, USLINKNO1 = 0

 

Line2: WSNO = 2, USLINKNO1 = 1

 

Line3: WSNO = 3, USLINKNO1 = 2

 

Line4: WSNO = 4, USLINKNO1 = 3

 

...

 

And when "WSNO" of the prior line is not equal to "USLINKNO1" of the current line, "_group" number will change (increment) for the next group.

 

It was my intention to use the "Prior/Subsequent Feature Attribute Retrieval" option and the "Conditional Value Setting" in the AttributeCreator.

 

 

Is the AttributeCreator working as expected?

---

Hi Takashi,

 

I'm confused...maybe i did something wrong...but i think you will check it immediately with these screenshots

 

shot1: my settings in the Attribute Creator

 

 

 

 

shot2: three results after Attribute Creator where you can see the attributes .....all three lines should be connected in the final........

 

 

 

 

 

 

so where is the fault?......now result is the line joiner in the end cannot connect it right because of wrong _group attributes......some lines have the right _group attributes but only a few......

---

The 1st line: WSNO=32535, USLINKNO1=32495, _group=8545

 

The 3rd line: WSNO=33303, USLINKNO1=32535, _group=8457

 

 

Since "WSNO" of the 1st line is equal to "USLINKNO1" of the 3rd line, the two line should have same "_group" if they are input to the AttributeCreator in the order of 1st ->  3rd continuously.

 

However, according to the values of "_group" (3rd:8457 < 1st:8545), the 3rd line has come earlier than the 1st line, and also they are not continuous in the input sequence.

 

Unfortunately, the precondition "input lines have been sorted in the connecting order" is not satisfied, at least in these two lines.

 

That's why the AttributeCreator doesn't work as expected.

 

 

Regarding the 1st line and the 2nd line, there is another short line between them, so I cannot check the reason that they were not connected.

---

Hi Takashi,

 

so i have to sort the lines before with LIne Joiner and the PathSplitter right?

here is also a screenshot from the little line between 1.shot and 2.shot

Thank you very much for taking time on this!!

 

 

---

1st, 2nd and the little line are also not continuous.

 

It's necessary to sort when adopting the AttributeCreator. But, since there are node to which 3 lines intersect together, the LineJoiner+PathSplitter method will not work perfectly.

 

I need to rethink...

---

At a node in which just two lines touch, the two lines can be connected always?

 

Or, could there also be a break point at such a node? 

---

at a node where only two lines touch the two lines can be connected always.!!

 

 

only on a point where three lines touch...can be 2 possibilities:

either all three lines are separated legs and belongs to three separate groups or

like the case you know from the screenshots....two lines had to be connected and one belongs to another stream.

---

Franco, unfortunately I was not able to find a way to resolve it by using existing transformers only. I finally fell into the temptation to use Python...

 

 

The PythonCaller with this script adds "_group" attribute to input features.

 

Set "_group" to the "Attributes To Expose" parameter of the PythonCaller.

 

Assume that both "WSNO" and "USLINKNO1" contain integer value and also there are no duplicate values in "WSNO" and "USLINKNO1".

 

You can remove the AttributeExposer and the AttributeCreator if you adopt this.

 

-----

 

# Python Script Example

 

import fme, fmeobjects

 

import collections

 

 

class FeatureProcessor(object):

 

    def __init__(self):

 

        # Set of all input features.

 

        self.features = set( ])

 

        

 

    def input(self, feature):

 

        # Store the input feature in the Set.

 

        self.features.add(feature)

 

        

 

    def close(self):

 

        # Connection key attribute names.

 

        frontAttr = 'USLINKNO1' # forward connection key

 

        backAttr = 'WSNO' # backword connection key

 

        

 

        # Create two dictionaries.

 

        # d1: key=forward connection key, value=feature

 

        # d2: key=backword connection key, value=feature

 

        d1, d2 = {}, {}

 

        for feature in self.features:

 

            front = int(feature.getAttribute(frontAttr))

 

            back = int(feature.getAttribute(backAttr))

 

            d1Afront] = feature

 

            d2Âback] = feature

 

 

        # Initialize group ID.

 

        id = 0

 

        

 

        while 0 < len(self.features):

 

            # Retrieve and remove a feature from the Set.

 

            feature = self.features.pop()

 

            

 

            # Create and initialize a group.

 

            group = collections.deque()

 

            group.append(feature)

 

            

 

            # Initialize forward/backward connection key.

 

            front = int(feature.getAttribute(frontAttr))

 

            back = int(feature.getAttribute(backAttr))

 

            

 

            # Append backward connectable features to the group.

 

            while d1.has_key(back):

 

                # - retrieve and remove a feature from d1 dictionary.

 

                # - append the feature to the group.

 

                # - remove the feature from the Set.

 

                # - update backword connection key.

 

                feature = d1.pop(back)

 

                group.append(feature)

 

                self.features.remove(feature)

 

                back = int(feature.getAttribute(backAttr))

 

                

 

            # Append forward connectable features to the group.

 

            while d2.has_key(front):

 

                # - retrieve and remove a feature from d2 dictionary.

 

                # - append the feature to the group.

 

                # - remove the feature from the Set.

 

                # - update forword connection key.

 

                feature = d2.pop(front)

 

                group.appendleft(feature)

 

                self.features.remove(feature)

 

                front = int(feature.getAttribute(frontAttr))

 

            

 

            # Set group ID and output features in the group.

 

            for feature in group:

 

                feature.setAttribute('_group', id)

 

                self.pyoutput(feature)

 

                

 

            # Update group ID for the next group.

 

            id += 1

 

-----

---

P.S. If you use the script, you can set "Yes" to the "Input is Ordered by Group" parameter of the following LineJoiner transformer.

---

A different approach flashed in my mind.

 

The basic strategy is: at the node where 3 lines are intersecting, shorten the line that should not be connected there so that it will not be treated by the LineJoiner; restore the shortened part by another LineJoiner later.

 

Right figure illustrates the situation after the shortening. The left-top line is the one that should not be connected at the node.

 

 

 

The data flow is a little complicated, so it's hard to explain correctly by my poor English.

 

See this demo workspace. (https://drive.google.com/file/d/0B0ufVP2t0eApX0ZnUllUblktczQ/view?usp=sharing)

---

The previous demo workspace didn't support the case where all the 3 lines should not be connected each other.

 

This is the upgrade version to support that case. (https://drive.google.com/file/d/0B0ufVP2t0eApM3VydkpDektPTGM/view?usp=sharing)

---