Skip to main content
Solved

How to turn fake holes into proper ones? Opposite of DonutBridgeBuilder?

tim_wood
Contributor
Forum|alt.badge.img+8

I have a polygon layer that has various geometry issues, mostly self-intersections. I have used the GeometryValidator to clean these up, but it has had the unfortunate consequence of filling in the holes. This is because they are not proper holes, but "fake" ones created by digitising a zero width corridor. So the hole boundary is actually part of the exterior boundary (highlighted in example below). The corridors are detected as self-intersections. Is there anything I can do to output the polygons with proper holes, or at least detect the polygons with fake holes so they can be edited manually? There are too many self-intersections reported by GeometryValidator to use for manually repairing the holes.

I've found this similar topic but I'm not quite sure if @offermann82 is looking for the same solution...

https://knowledge.safe.com/questions/59610/how-to-split-polygons-with-holes-that-touch-the-bo.html

I think I want the opposite of what DonutBridgeBuilder does...

https://docs.safe.com/fme/2018.0/html/FME_Desktop_Documentation/FME_Transformers/Transformers/donutbridgebuilder.htm

I'll try overlaying/comparing the unrepaired polygons with the repaired ones to try and catch the bits that have been filled in but I'm not sure if this will be affected by self-intersections and tiny geometry changes resulting from GeometryValidator repairs.

Best answer by takashi

@egomm is right. It's the reason why the GeometryValidator (Self-Intersections in 2D) repairs the geometry to fill the "fake holes". In this case, the GeometryValidator won't work as expected.

 

Further, the geometry has many duplicate consecutive vertices, and also there seems to be tiny gaps between the segments forming the "corridor". It's the reason why @david_r's method didn't work.

 

In order to clean the geometry up, consider adding the GeometryValidator (Issue to Detect: Duplicate Consecutive Points) and the Snapper to the workflow. e.g.

 

View original
Did this help you find an answer to your question?

12 replies

david_r
Celebrity
  • david_rCelebrity
  • September 20, 2018

Here's one way to get rid of the yellow lines and get "proper" donuts:

  1. Counter to assign a unique id to each polygon
  2. Chopper with max 2 vertices
  3. AreaBuilder with group by on the counter value, drop donut holes set to yes

If you need to, you can then use the Matcher between the before/after polygons to see which ones changed as a result of this operation, which is maybe what you're looking for.

richardt
1 person upvoted this
  • richardt
    richardt
takashi
Influencer
  • takashiInfluencer
  • September 20, 2018

The GeometryValidator (Issue to Detect: Self-Intersections in 2D, Attempt Repair: Yes) could transform polygons with "fake holes" into donuts with "proper holes". Check the resulting features output via the Repaired port.

tim_wood
Contributor
Forum|alt.badge.img+8
  • tim_woodContributor
  • Author
  • Contributor
  • September 21, 2018
takashi wrote:

The GeometryValidator (Issue to Detect: Self-Intersections in 2D, Attempt Repair: Yes) could transform polygons with "fake holes" into donuts with "proper holes". Check the resulting features output via the Repaired port.

Repairing self-intersections in 2D is what is causing the holes to be filled in.

 

tim_wood
Contributor
Forum|alt.badge.img+8
  • tim_woodContributor
  • Author
  • Contributor
  • September 21, 2018
david_r wrote:

Here's one way to get rid of the yellow lines and get "proper" donuts:

  1. Counter to assign a unique id to each polygon
  2. Chopper with max 2 vertices
  3. AreaBuilder with group by on the counter value, drop donut holes set to yes

If you need to, you can then use the Matcher between the before/after polygons to see which ones changed as a result of this operation, which is maybe what you're looking for.

I've tried that but the output looks the same as the input.

 

takashi
Influencer
  • takashiInfluencer
  • September 21, 2018
takashi wrote:

The GeometryValidator (Issue to Detect: Self-Intersections in 2D, Attempt Repair: Yes) could transform polygons with "fake holes" into donuts with "proper holes". Check the resulting features output via the Repaired port.

Filling holes won't happen theoretically. There might be some other issues on the geometries. Could you please share a minimal sample data that contains the polygon features having "fake holes"?

 

 

tim_wood
Contributor
Forum|alt.badge.img+8
  • tim_woodContributor
  • Author
  • Contributor
  • September 21, 2018
takashi wrote:
Filling holes won't happen theoretically. There might be some other issues on the geometries. Could you please share a minimal sample data that contains the polygon features having "fake holes"?

 

 

I've attached an example polygon as Well Known Binary (WKB) and Well Known Text (WKT). The source data is an SQL Server table where the geometry is stored as WKB but in a varbinary(max) column, not a geometry type column. So to create the geometry in FME, I'm using a GeometryReplacer with Hex Encoded OGC Well Known Binary as the encoding format. The GeometryReplacer is not filling in the holes as I have written out the result to an FGDB before using GeometryValidator and the hole is still there.

 

polygon-with-holes-as-wkt.txt

 

polygon-with-holes-as-wkb.txt

 

ebygomm
Influencer
Forum|alt.badge.img+33
  • ebygommInfluencer
  • Influencer
  • September 21, 2018
Your geometry is actually 'twisted' - it's not just a case of it containing a zero width corridor.

 

 

The line shows the order of the points

 

 

 

 

ebygomm
Influencer
Forum|alt.badge.img+33
  • ebygommInfluencer
  • Influencer
  • September 21, 2018
Your geometry is actually 'twisted' - it's not just a case of it containing a zero width corridor.

 

 

The line shows the order of the points

 

 

 

 

tim_wood
Contributor
Forum|alt.badge.img+8
  • tim_woodContributor
  • Author
  • Contributor
  • September 21, 2018
ebygomm wrote:
Your geometry is actually 'twisted' - it's not just a case of it containing a zero width corridor.

 

 

The line shows the order of the points

 

 

 

 

Ah! Is that why it's getting filled in by the self-intersection repair?

 

I wondered if it might be possible to use an unrepaired version of the data to cut out the holes in the repaired version but that could also affect valid repairs....

 

takashi
Influencer
  • takashiInfluencer
  • Best Answer
  • September 22, 2018
@egomm is right. It's the reason why the GeometryValidator (Self-Intersections in 2D) repairs the geometry to fill the "fake holes". In this case, the GeometryValidator won't work as expected.

 

Further, the geometry has many duplicate consecutive vertices, and also there seems to be tiny gaps between the segments forming the "corridor". It's the reason why @david_r's method didn't work.

 

In order to clean the geometry up, consider adding the GeometryValidator (Issue to Detect: Duplicate Consecutive Points) and the Snapper to the workflow. e.g.

 

takashi
Influencer
  • takashiInfluencer
  • September 22, 2018
ebygomm wrote:
Your geometry is actually 'twisted' - it's not just a case of it containing a zero width corridor.

 

 

The line shows the order of the points

 

 

 

 

@egomm is right. It's the reason why the GeometryValidator (Self-Intersections in 2D) repairs the geometry to fill the "fake holes". In this case, the GeometryValidator won't work as expected.

 

Further, the geometry has many duplicate consecutive vertices, and also there seems to be tiny gaps between the segments forming the "corridor". It's the reason why @david_r's method didn't work.

 

In order to clean the geometry up, consider adding the GeometryValidator (Issue to Detect: Duplicate Consecutive Points) and the Snapper to the workflow. e.g.

 

tim_wood
Contributor
Forum|alt.badge.img+8
  • tim_woodContributor
  • Author
  • Contributor
  • September 25, 2018
takashi wrote:
@egomm is right. It's the reason why the GeometryValidator (Self-Intersections in 2D) repairs the geometry to fill the "fake holes". In this case, the GeometryValidator won't work as expected.

 

Further, the geometry has many duplicate consecutive vertices, and also there seems to be tiny gaps between the segments forming the "corridor". It's the reason why @david_r's method didn't work.

 

In order to clean the geometry up, consider adding the GeometryValidator (Issue to Detect: Duplicate Consecutive Points) and the Snapper to the workflow. e.g.

 

Thanks @takashi @egomm and @david_r that's fixed that example :-)

 

I think there's a bit more work for me to do to test this with other polygons in the same layer that don't have "fake" holes, but may have their own issues e.g. more typical self-intersections. It's a good lesson in A) digitising features properly; B) deciding whether you're going to get FME to fix issues or simply report them.

Reply


Helpful Members This Week

Community Stats

31,207
Posts
118,312
Replies
38,811
Members

Latest FME

Terms & ConditionsCookie settings

Cookie policy

We use cookies to enhance and personalize your experience. If you accept you agree to our full cookie policy. Learn more about our cookies.

 
Cookie settings
A product of
Safe Software respectfully acknowledges that we live, learn and work on the traditional and unceded territories of the Kwantlen, Katzie, and Semiahmoo First Nations.