Hi @takashi
re ListBuilder: you would prefer Input Ordered parameter to be right after Group By, am I correct? This would be the same dialog structure as e.g. in FeatureMerger.
Hi @takashi
re ListBuilder: you would prefer Input Ordered parameter to be right after Group By, am I correct? This would be the same dialog structure as e.g. in FeatureMerger.
Yes.As far as I know, in other transformers that have the Input Ordered parameter (including the ListBuilder itself in FME 2017.0 and eralier), the parameter is generally within the parameters group "Transformer". I think it's better to arrange the parameter close to the Group By parameter.
Yes.As far as I know, in other transformers that have the Input Ordered parameter (including the ListBuilder itself in FME 2017.0 and eralier), the parameter is generally within the parameters group "Transformer". I think it's better to arrange the parameter close to the Group By parameter.
Agree. I have filed a PR asking to place the parameter below Group By.
Good catch re: the ListBuilder. We'll address.
But the NeighbourFinder I don't know what the best default is. @takashi -- do you think No is better. Is there a downside to transferring elevation?
Good catch re: the ListBuilder. We'll address.
But the NeighbourFinder I don't know what the best default is. @takashi -- do you think No is better. Is there a downside to transferring elevation?
I'm afraid there could be scenarios where the user doesn't expect the original z-coordinates of base 3D points will be changed. If they didn't set 'No' to the parameter, z of points would be changed unexpectedly. In a case, the 3D point would be forced into 2D points if the closest candidate line was 2D.
Hi @takashi
re ListBuilder: you would prefer Input Ordered parameter to be right after Group By, am I correct? This would be the same dialog structure as e.g. in FeatureMerger.
@LenaAtSafe, thanks for filing the PR.
Good catch re: the ListBuilder. We'll address.
But the NeighbourFinder I don't know what the best default is. @takashi -- do you think No is better. Is there a downside to transferring elevation?
Regarding the NeighborFinder parameters, I have another interesting discovery.
The help documentation says:
"A value must be specified for at least one of the Number of Neighbors to Find and Maximum Distance parameters."
"Note: To get the distance from a given Base to all Candidate features, use a very large number for this parameter and specify a Close Candidate List Name."
However, in fact, you can leave both the Number of Neighbors to Find and Maximum Distance parameters blank to get the distance from a given Base to all Candidate features.
I think the help should be updated if it's an intentional behavior.
Hi @takashi,
Your suggestions and corrections have implemented in FME 2017 build 17645 and FME 2018 beta build 18176. Thank you for helping us make FME even better!
Regarding the NeighborFinder parameters, I have another interesting discovery.
The help documentation says:
"A value must be specified for at least one of the Number of Neighbors to Find and Maximum Distance parameters."
"Note: To get the distance from a given Base to all Candidate features, use a very large number for this parameter and specify a Close Candidate List Name."
However, in fact, you can leave both the Number of Neighbors to Find and Maximum Distance parameters blank to get the distance from a given Base to all Candidate features.
I think the help should be updated if it's an intentional behavior.
Hi @takashi
I have PRed this as well. I believe the leaving blank behaviour is by design. If this indeed is the case, we will update the transformer description. Thank you for catching this mismatch.
Hi @takashi
I have PRed this as well. I believe the leaving blank behaviour is by design. If this indeed is the case, we will update the transformer description. Thank you for catching this mismatch.
Hi @LenaAtSafe, thanks for filing that. In addition, this setting is also available to find all Candidates for every Base.
- Number of Neighbors to Find: 0
- Maximum Distance: <not set>
Hi @LenaAtSafe, thanks for filing that. In addition, this setting is also available to find all Candidates for every Base.
- Number of Neighbors to Find: 0
- Maximum Distance: <not set>
Let me add this to the PR.
Let me add this to the PR.
Hi @takashi The doc re the NeighborFinder has been updated in FME 2018.0
